Christoph Hellwig <[email protected]> writes:
>> - if (use_plug && !blk_queue_nomerges(q) &&
>> + if (likely(!is_flush_fua) && !blk_queue_nomerges(q) &&
>
> Please don't sprinkle likely annotations for no go reason. Especially
> on metadata write heavy workloads (e.g. an NFS server) it might be very
> likely.
I have no problem getting rid of the likely, but I was mimicing the mq
case:
blk_mq_make_request:
if (unlikely(is_flush_fua)) {
blk_mq_bio_to_request(rq, bio);
blk_insert_flush(rq);
goto run_queue;
}
So would you also want that unlikely removed?
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
