> On 18 May 2015 at 19:19 Al Viro <[email protected]> wrote: > > > On Mon, May 18, 2015 at 07:13:48PM +0200, Fabian Frederick wrote: > > * If the block order is wrong, swap the arguments. > > */ > > - if ((swap = xfs_dir2_leafn_order(dp, blk1->bp, blk2->bp))) { > > - xfs_da_state_blk_t *tmp; /* temp for block swap */ > > + swap = xfs_dir2_leafn_order(dp, blk1->bp, blk2->bp); > > + if (swap) > > + swap(blk1, blk2); > > Egads... Have you even read what you'd written? Yes, sure, preprocessor > will do the right thing, but it's a very noticable annoyance for somebody > reading that. Rename the bleeding flag, please.
I wanted to focus on the swap() update in this small patchset (some other things should be done in there like have xfs_dir2_leafn_order() return bool) but I can rename it in something like need_swap. Do I need to resend the 4 patches Dave ? Regards, Fabian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
