On Fri, May 15, 2015 at 11:43:59PM +0200, Fabian Frederick wrote:
> else is not needed after break in dbg_check_old_index()
> This also solves the {} parity.
>
> Signed-off-by: Fabian Frederick <f...@skynet.be>
> ---
> fs/ubifs/commit.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ubifs/commit.c b/fs/ubifs/commit.c
> index 63f5661..dd9ba81 100644
> --- a/fs/ubifs/commit.c
> +++ b/fs/ubifs/commit.c
> @@ -680,9 +680,9 @@ int dbg_check_old_index(struct ubifs_info *c, struct
> ubifs_zbranch *zroot)
> if (iip + 1 < le16_to_cpu(idx->child_cnt)) {
> iip = iip + 1;
> break;
> - } else
> - /* Nope, so go up again */
> - iip = i->iip;
> + }
> + /* Nope, so go up again */
> + iip = i->iip;
> }
> } else
> /* Go down left */
I think the 'else' structure makes things clearer, so I'd personally
just fix the braces. But of course coding style is more opinion than
science.
Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
