On Wed, May 27, 2015 at 10:24:40AM +0100, Lee Jones wrote: > On Mon, 25 May 2015, Charles Keepax wrote: > > > Add helpers to read u32's and arrays of u32's from device tree or ACPI > > using the new device properties API. > > > > Signed-off-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> > > --- > > drivers/mfd/arizona-core.c | 39 > > ++++++++++++++++++++++++++++++++++++++ > > include/linux/mfd/arizona/core.h | 5 ++++ > > 2 files changed, 44 insertions(+), 0 deletions(-) > > Me no likey! > > There are 100's of 'required' and 'optional' properties in the kernel > and it's normally the decision to early return or not that seals the > fate of a given driver. I'm not happy for platforms to start adding > their own variants. > > If you really do think these kinds of "helpers" add value, then make > them generic, so everyone can make use of them. Personally, I'm > dubious however.
Thats cool I don't really have any problem with dropping this patch and doing the necessary checking where appropriate. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
