Thanks for the review, Greg. I've fixed the things you've noted. I have removed the call to ion_device_destroy() in the ion_physmem_remove() and added a comment about it. We won't unload the driver anyway for now. I admit, integer counting was a dirty hack there, but struct ion_device contents are private to ion.c, so ion drivers can't access them. Unless I'm missing something, settling on only removing heaps is the only right way to do it right now. Correct me if I'm wrong.
Thanks, Andrew. Andrew 'Necromant' Andrianov (2): staging: ion: Add generic ion-physmem driver staging: ion: Add ion-physmem documentation Documentation/devicetree/bindings/ion,physmem.txt | 96 +++++++++ drivers/staging/android/ion/Kconfig | 7 + drivers/staging/android/ion/Makefile | 5 +- drivers/staging/android/ion/ion_physmem.c | 229 ++++++++++++++++++++++ include/dt-bindings/ion,physmem.h | 17 ++ 5 files changed, 352 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/ion,physmem.txt create mode 100644 drivers/staging/android/ion/ion_physmem.c create mode 100644 include/dt-bindings/ion,physmem.h -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
