Hello Krzysztof, On Mon, Jun 8, 2015 at 3:35 AM, Krzysztof Kozlowski <[email protected]> wrote: > During probe the regulator (if present) was enabled but not disabled in > case of failure. So an unsuccessful probe lead to enabling the > regulator which was actually not needed because the device was not > enabled. > > Additionally each deferred probe lead to increase of regulator enable > count so it would not be effectively disabled during removal of the > device. > > Signed-off-by: Krzysztof Kozlowski <[email protected]> > Fixes: 498d22f616f6 ("thermal: exynos: Support for TMU regulator defined at > device tree") > Cc: <[email protected]> >
Reviewed-by: Javier Martinez Canillas <[email protected]> > --- > > I am not entirely convinced that this should go to stable. Leaving a > regulator enabled in case of probe failure (no exynos TMU device) or > after deferred probe (regulator won't be disabled during device removal) > is not a critical issue, just leaks power. Yes, as you said leaving the regulator enabled is not critical but OTOH is a very small patch and is fixing a very evident bug so I think it's OK. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
