On Thu, Jun 04, 2015 at 12:06:09AM -0700, Nicholas A. Bellinger wrote: > So I've been using tcm_loop + RAMDISK backends for prototyping, but this > patch is intended for vhost-scsi so it can avoid the unnecessary > queue_work() context switch within target_complete_cmd() for all backend > driver types. > > This is because vhost_work_queue() is just updating vhost_dev->work_list > and immediately wake_up_process() into a different vhost_worker() > process context. For heavy small block workloads into fast IBLOCK > backends, avoiding this extra context switch should be a nice efficiency > win.
How about trying to merge the two workers instead? > Perhaps tcm_loop LLD code should just be limited to RAMDISK here..? I'd prefer to not do it especially for the loopback code, as that should serve as a simple example. But before making further judgement I'd really like to see the numbers. Note that something that might help much more is getting rid of the remaining irq or bh disabling spinlocks in the target core, as that tends to introduce a lot of additional latency. Moving additional code to hardirq context is fairly diametrical to that design. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
