On Sat, 16 May 2015, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.este...@freescale.com>
>
> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
> bogus threaded irq requests") threaded IRQs without a primary handler
> need to be requested with IRQF_ONESHOT, otherwise the request will fail.
>
> So pass the IRQF_ONESHOT flag in this case.
>
> The semantic patch that makes this change is available
> in scripts/coccinelle/misc/irqf_oneshot.cocci.
>
> Signed-off-by: Fabio Estevam <fabio.este...@freescale.com>
> ---
> drivers/mfd/twl4030-irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
> index 1b772ef..a3fa7f4 100644
> --- a/drivers/mfd/twl4030-irq.c
> +++ b/drivers/mfd/twl4030-irq.c
> @@ -674,7 +674,7 @@ int twl4030_sih_setup(struct device *dev, int module, int
> irq_base)
> irq_set_handler_data(irq, agent);
> agent->irq_name = kasprintf(GFP_KERNEL, "twl4030_%s", sih->name);
> status = request_threaded_irq(irq, NULL, handle_twl4030_sih,
> - IRQF_EARLY_RESUME,
> + IRQF_EARLY_RESUME | IRQF_ONESHOT,
> agent->irq_name ?: sih->name, NULL);
>
> dev_info(dev, "%s (irq %d) chaining IRQs %d..%d\n", sih->name,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
