On 15-06-15 03:35 AM, Jesper Nilsson wrote: > On Sun, Jun 14, 2015 at 05:05:21PM -0400, Paul Gortmaker wrote: >> The eeprom.c code is compiled based on the Kconfig setting >> ETRAX_I2C_EEPROM, which is bool. So the code is either built in >> or absent. It will never be modular, so using module_init as an >> alias for __initcall is rather misleading. >> >> Fix this up now, so that we can relocate module_init from >> init.h into module.h in the future. If we don't do this, we'd >> have to add module.h to obviously non-modular code, and that >> would be a worse thing. >> >> Direct use of __initcall is discouraged, vs prioritized ones. >> Use of device_initcall is consistent with what __initcall >> maps onto, and hence does not change the init order, making the >> impact of this change zero. Should someone with real hardware >> for boot testing want to change it later to arch_initcall or >> something different, they can do that at a later date. >> >> Cc: Mikael Starvik <[email protected]> > > Looks good, I'll take it in the CRIS-tree.
That is fine if you want, but I need to keep a copy here in this series (as per the part of the msg you snipped) ; otherwise I'll introduce a bisect fail into the commit history if my tree gets merged ahead of the cris tree. Thanks, Paul. -- > >> Cc: [email protected] >> Signed-off-by: Paul Gortmaker <[email protected]> > > /^JN - Jesper Nilsson > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
