* Rik van Riel <[email protected]> [2015-06-16 11:00:18]: > On 06/16/2015 07:56 AM, Srikar Dronamraju wrote: > > In task_numa_migrate(), while evaluating other nodes for group > > consolidation, env.dst_nid is used instead of using the iterator nid. > > Using env.dst_nid would mean dist is always the same. Infact the same > > dist was calculated above while evaluating the preferred node. > > > > Fix the above to use the iterator nid. > > Good catch. > > > Also the task/group weights from the src_nid should be calculated > > irrespective of numa topology type. > > If you look at score_nearby_nodes(), you will see that > maxdist is only used when the topology is NUMA_BACKPLANE. > > The source score never changes when having a directly > connected or NUMA_GLUELESS_MESH type system, so the source > score does not need to be recalculated unless we are actually > dealing with a NUMA_BACKPLANE topology. > > Looking forward to a v2 with just the first fix.
Okay, will fix accordingly. -- Thanks and Regards Srikar Dronamraju -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
