Hello, Peter. On Mon, Jun 29, 2015 at 11:32:19AM +0200, Peter Zijlstra wrote: > Agreed, luckily we already have the infrastructure for this, something > like so? > > --- a/include/linux/percpu-defs.h > +++ b/include/linux/percpu-defs.h > @@ -287,6 +287,16 @@ do { > \ > preempt_enable(); \ > } while (0) > > +#define per_cpu_sum(var) \ > +({ \ > + typeof(var) __sum = 0; \ > + int cpu; \
Why not __cpu? > + compiletime_assert_atomic_type(__sum); \ > + for_each_possible_cpu(cpu) \ > + __sum += per_cpu(var, cpu); \ > + __sum; \ > +}) But other than that, looks good to me. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/