On Thu, Jun 25, 2015 at 5:29 PM, Michal Simek <michal.si...@xilinx.com> wrote: > Add missing pm_runtime_disabled to remove(). > > Error log: > root@zynqmp:~# modprobe gpio_zynq > root@zynqmp:~# lsmod > Not tainted > gpio_zynq 7086 0 - Live 0xffffffbffc00a000 > root@zynqmp:~# rmmod gpio_zynq > root@zynqmp:~# lsmod > Not tainted > root@zynqmp:~# modprobe gpio_zynq > [ 246.924438] zynq-gpio ff0a0000.gpio: Unbalanced pm_runtime_enable! > root@zynqmp:~# rmmod gpio_zynq > root@zynqmp:~# lsmod > Not tainted
Yup, this was missing indeed. Reviewed-by: Alexandre Courbot <acour...@nvidia.com> > > Signed-off-by: Michal Simek <michal.si...@xilinx.com> > --- > > drivers/gpio/gpio-zynq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c > index 2e87c4b8da26..a78882389836 100644 > --- a/drivers/gpio/gpio-zynq.c > +++ b/drivers/gpio/gpio-zynq.c > @@ -757,6 +757,7 @@ static int zynq_gpio_remove(struct platform_device *pdev) > gpiochip_remove(&gpio->chip); > clk_disable_unprepare(gpio->clk); > device_set_wakeup_capable(&pdev->dev, 0); > + pm_runtime_disable(&pdev->dev); > return 0; > } > > -- > 2.3.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
