Subject suggestion: "staging: android: uapi: remove unnecessary typedef"
That makes it immediately clear what the issue is. On Wed, Jul 1, 2015 at 3:47 PM, Sohny Thomas <[email protected]> wrote: > > As per checkpatch.pl remove unnecessary typedef > Here ion_user_handle_t was used only in the header . > > Signed-of-by: Sohny Thomas <[email protected]> Typo here as well. > --- > drivers/staging/android/uapi/ion.h | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/android/uapi/ion.h > b/drivers/staging/android/uapi/ion.h > index 68a14b4..9897403 100644 > --- a/drivers/staging/android/uapi/ion.h > +++ b/drivers/staging/android/uapi/ion.h > @@ -20,7 +20,6 @@ > #include <linux/ioctl.h> > #include <linux/types.h> > > -typedef int ion_user_handle_t; > I would expect an extra line to be removed here. This will leave two empty lines. > /** > * enum ion_heap_types - list of all possible types of heaps > @@ -88,7 +87,7 @@ struct ion_allocation_data { > size_t align; > unsigned int heap_id_mask; > unsigned int flags; > - ion_user_handle_t handle; > + int handle; > }; > > /** > @@ -102,7 +101,7 @@ struct ion_allocation_data { > * provides the file descriptor and the kernel returns the handle. > */ > struct ion_fd_data { > - ion_user_handle_t handle; > + int handle; > int fd; > }; > > @@ -111,7 +110,7 @@ struct ion_fd_data { > * @handle: a handle > */ > struct ion_handle_data { > - ion_user_handle_t handle; > + int handle; > }; > > /** > -- > > > > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
