On Fri 22-05-15 17:14:04, Tejun Heo wrote: > __mpage_writepage() is used to implement mpage_writepages() which in > turn is used for ->writepages() of various filesystems. All writeback > logic is now updated to handle cgroup writeback and the block cgroup > to issue IOs for is encoded in writeback_control and can be retrieved > from the inode; however, __mpage_writepage() currently ignores the > blkcg indicated by the inode and issues all bio's without explicit > blkcg association. > > This patch updates __mpage_writepage() so that the issued bio's are > associated with inode_to_writeback_blkcg_css(inode). > > v2: Updated for per-inode wb association.
Looks good. You can add: Reviewed-by: Jan Kara <[email protected]> Honza > > Signed-off-by: Tejun Heo <[email protected]> > Cc: Jens Axboe <[email protected]> > Cc: Jan Kara <[email protected]> > Cc: Andrew Morton <[email protected]> > Cc: Alexander Viro <[email protected]> > --- > fs/mpage.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/mpage.c b/fs/mpage.c > index 3e79220..a3ccb0b 100644 > --- a/fs/mpage.c > +++ b/fs/mpage.c > @@ -605,6 +605,8 @@ static int __mpage_writepage(struct page *page, struct > writeback_control *wbc, > bio_get_nr_vecs(bdev), GFP_NOFS|__GFP_HIGH); > if (bio == NULL) > goto confused; > + > + bio_associate_blkcg(bio, inode_to_wb_blkcg_css(inode)); > } > > /* > -- > 2.4.0 > -- Jan Kara <[email protected]> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
