Just two nits. On ma, 2015-07-06 at 07:47 -0700, Dexuan Cui wrote: > --- /dev/null > +++ b/net/hv_sock/Kconfig
> +config HYPERV_SOCK > + tristate "Microsoft Hyper-V Socket (EXPERIMENTAL)" > + depends on HYPERV > + default m > + help > + Hyper-V Socket is a socket protocol similar to TCP, allowing > + communication between a Linux guest and the host. > + > + To compile this driver as a module, choose M here: the module > + will be called hv_sock. If unsure, say N. It's a bit odd to advise to say N if one is unsure and set the default to 'm' at the same time. > --- /dev/null > +++ b/net/hv_sock/af_hvsock.c > +static int hvsock_init(void) > +{ > + [...] > +} > + > +static void hvsock_exit(void) > +{ > + [...] > +} > + > +module_init(hvsock_init); > +module_exit(hvsock_exit); Any specific reason not to mark these functions __init and __exit? Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/