On Tue, Jul 07, 2015 at 11:21:09PM +0900, Sergey Senozhatsky wrote: > On (07/07/15 22:39), Minchan Kim wrote: > [..] > > > struct zs_pool_stats { > > > - /* How many objects were migrated */ > > > - u64 num_migrated; > > > + /* How many pages were migrated (freed) */ > > > + u64 pages_compacted; > > > > Hmm, if we account it as page unit, unsigned long is enough for 32bit. > > Well, this is a 'how many pages were freed overall' counter. We don't > control the lifetime of device, so I think it can be bigger than 4 bytes > in some `extreme' cases.
Technically, you're right but we have been used "unsigned long" for seval mm stats for a long time. For exmaple, vm_event_item. It includes many stats accumulated for the system running time. I don't think zsmalloc is special. > > -ss -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/