On (07/07/15 22:44), Minchan Kim wrote: [..] > IMO, there is no value to maintain just in case of > failing register_shrinker in practice. > > Let's remove shrinker_enabled and abort pool creation if shrinker register > is failed.
But why would we do this? Yes, it's kinda-sorta bad -- we were not able to register zspool shrinker, so there will be no automatic compaction... And that's it. It does not affect zsmalloc/zram functionality by any means. Including compaction itself -- user still has a way to compact zspool (manually). And in some scenarios user will never even see automatic compaction in action (assuming that there is a plenty of RAM available). Can you explain your decision? -ss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/