On 07/07/2015 04:37 PM, Roger Quadros wrote: >>>> diff --git a/drivers/net/can/c_can/c_can.c >>>> b/drivers/net/can/c_can/c_can.c >>>> index 041525d..66e98e7 100644 >>>> --- a/drivers/net/can/c_can/c_can.c >>>> +++ b/drivers/net/can/c_can/c_can.c >>>> @@ -605,7 +605,18 @@ static int c_can_start(struct net_device *dev) >>>> priv->can.state = CAN_STATE_ERROR_ACTIVE; >>>> >>>> /* activate pins */ >>>> - pinctrl_pm_select_default_state(dev->dev.parent); >>>> +#ifdef CONFIG_PINCTRL >>> >>> Please remove the ifdef, AFAICS there are static inline noop functions >>> if CONFIG_PINCTRL switched off. >> >> yes, you are right. > > On second thoughts > > device->pins are not defined if CONFIG_PINCTRL is not set. > so we can't remove the #ifdef.
Too bad :( okay - should I add [email protected] on Cc? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
