On 14.07.2015 05:42, Stephen Boyd wrote: > On 07/11/2015 12:07 AM, Krzysztof Kozlowski wrote: >> W dniu 11.07.2015 o 08:33, Stephen Boyd pisze: >> >>> diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c >>> index 0117238391d6..f38a6c49f744 100644 >>> --- a/drivers/clk/samsung/clk.c >>> +++ b/drivers/clk/samsung/clk.c >>> @@ -11,6 +11,10 @@ >>> * clock framework for Samsung platforms. >>> */ >>> +#include <linux/slab.h> >>> +#include <linux/clkdev.h> >>> +#include <linux/clk.h> >>> +#include <linux/clk-provider.h> >>> #include <linux/of_address.h> >>> #include <linux/syscore_ops.h> >>> diff --git a/drivers/clk/samsung/clk.h b/drivers/clk/samsung/clk.h >>> index b775fc29caa5..aa872d2c5105 100644 >>> --- a/drivers/clk/samsung/clk.h >>> +++ b/drivers/clk/samsung/clk.h >>> @@ -13,10 +13,11 @@ >>> #ifndef __SAMSUNG_CLK_H >>> #define __SAMSUNG_CLK_H >>> -#include <linux/clkdev.h> >>> #include <linux/clk-provider.h> >>> #include "clk-pll.h" >>> +struct clk; >>> + >> Hmmm... why? Including clk-provider (which declares struct clk in your >> last patch) is not sufficient? >> > > I hope to eventually remove the forward declaration of struct clk in > clk-provider.h too. That will take some more time though. I can leave > this part out of the patch if you like and add it back when that work is > done, it doesn't matter to me.
Thanks for explanation, it's fine as it is. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/