On 2015-07-03 오후 2:03, SungEun Kim(cleaneye....@lge.com) wrote: > On 2015-07-03 오전 9:15, Rafael J. Wysocki wrote: >> On Wednesday, July 01, 2015 05:28:48 PM SungEun Kim wrote: >>> From: "SungEun Kim" <cleaneye....@lge.com> >>> >>> The synchronous synchronize_rcu in wakeup_source_remove makes user >> process >>> which writes to /sys/kernel/wake_unlock blocked sometimes. >>> >>> For example, when android eventhub tries to release wakelock, >>> this blocking process can occur, and eventhub can't get input event >>> for a while. >>> >>> Using workqueue instead of direct function call at pm_wake_unlock >>> can prevent this unnecessary delay of an user space process. >> >> The idea is defendable, but the patch is too simple. >> >> For example, if the garbage collection is in progress, it is not useful >> to start a new one. >> >> Also the incrementation and clearing of wakelocks_gc_count should be under >> the lock. > > Thank you for your advices. > I will correct and amend my patch and then submit v3 patch. > > Thank you. > SungEun Kim >
Dear Wysocki, I've submit patch v3. Could you review patch v3? Thank you. SungEun Kim >> >> >> -- >> I speak only for myself. >> Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
