Hi Dinh, On 21 July 2015 at 08:22, Dinh Nguyen <dingu...@opensource.altera.com> wrote: > On Tue, 21 Jul 2015, Tyler Baker wrote: > >> Hi, >> >> On 17 July 2015 at 17:53, Stephen Boyd <sb...@codeaurora.org> wrote: >> > On 07/06, dingu...@opensource.altera.com wrote: >> >> From: Dinh Nguyen <dingu...@opensource.altera.com> >> >> >> >> Use of_clk_parent_fill to fill in the parent clock names' array. >> >> >> >> Signed-off-by: Dinh Nguyen <dingu...@opensource.altera.com> >> >> Cc: Maxime Ripard <maxime.rip...@free-electrons.com> >> >> Cc: "Emilio López" <emi...@elopez.com.ar> >> >> --- >> > >> > Applied to clk-next with that fix I posted. >> >> The kernelci.org bot reported sunxi a20 boot failures[1][2] in >> next-20150720 and next-20150721. I have bisected[3] these failures to >> this commit. However, I have not investigated any further but >> reverting this commit on top of next-20150721 gets the boards booting >> again. >> > > Can you please try this patch?
I've tested the patch below on top of next-20150721 and can confirm it fixes the sunxi a20 issues I've reported. > -->8- > > diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c > index e8c5185..958655f 100644 > --- a/drivers/clk/sunxi/clk-sunxi.c > +++ b/drivers/clk/sunxi/clk-sunxi.c > @@ -204,7 +204,7 @@ static void __init sun6i_ahb1_clk_setup(struct > device_node *node) > return; > > /* we have a mux, we will have >1 parents */ > - of_clk_parent_fill(node, parents, SUN6I_AHB1_MAX_PARENTS); > + i = of_clk_parent_fill(node, parents, SUN6I_AHB1_MAX_PARENTS); > of_property_read_string(node, "clock-output-names", &clk_name); > > ahb1 = kzalloc(sizeof(struct sun6i_ahb1_clk), GFP_KERNEL); > @@ -789,7 +789,7 @@ static void __init sunxi_mux_clk_setup(struct device_node > *node, > > reg = of_iomap(node, 0); > > - of_clk_parent_fill(node, parents, SUNXI_MAX_PARENTS); > + i = of_clk_parent_fill(node, parents, SUNXI_MAX_PARENTS); > of_property_read_string(node, "clock-output-names", &clk_name); > > clk = clk_register_mux(NULL, clk_name, parents, i, Thanks, Tyler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
