On 23/07/15 14:06, Bjorn Helgaas wrote:
> On Thu, Jul 23, 2015 at 10:26:23AM +0100, Marc Zyngier wrote:
>> In order to be able to populate the device msi_domain field,
>> add the necessary hooks to propagate the host bridge msi_domain
>> across secondary busses to devices.
>>
>> So far, nobody populates the initial msi_domain.
>>
>> Signed-off-by: Marc Zyngier <marc.zyng...@arm.com>
> 
> Acked-by: Bjorn Helgaas <bhelg...@google.com>
> 
>> +static void pci_set_msi_domain(struct pci_dev *dev)
>> +{
>> +    /*
>> +     * If no domain has been set through the pcibios callback,
>> +     * inherit the default from the bus device.
> 
> Nit: there isn't a pcibios callback anymore.

There is actually one, in pci_add_device:

        [...]
        ret = pcibios_add_device(dev);
        WARN_ON(ret < 0);

        /* Setup MSI irq domain */
        pci_set_msi_domain(dev);
        [...]

pcibios_add_device is the one I was referring to. I'll clarify the comment.

Thanks,

        M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to