On Tue, Jul 28, 2015 at 02:48:09PM +0200, Linus Walleij wrote:
> On Tue, Jul 28, 2015 at 9:48 AM, Ludovic Desroches
> <ludovic.desroc...@atmel.com> wrote:
>
> > From: David Dueck <davidcdu...@googlemail.com>
> >
> > Not all gpio banks are necessarily enabled, in the current code this can
> > lead to null pointer dereferences.
> >
> > [ 51.130000] Unable to handle kernel NULL pointer dereference at virtual
> > address 00000058
> (...)
> >
> > Signed-off-by: David Dueck <davidcdu...@googlemail.com>
> > Acked-by: Ludovic Desroches <ludovic.desroc...@atmel.com>
> > Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
> > CC: Nicolas Ferre <nicolas.fe...@atmel.com>
> > CC: Boris Brezillon <boris.brezil...@free-electrons.com>
> > CC: linux-arm-ker...@lists.infradead.org
> > CC: linux-kernel@vger.kernel.org
> > ---
> >
> > This patch fixes a oops in the kernel because of a NULL pointer in a table.
> > Having a NULL pointer in this table is the normal behavior if a PIO
> > controller
> > is not enabled. So this fix is not a quick and dirty hack, it's usual to
> > skip
> > an entry from a table if it is not filled.
>
> Fair enough, better too many checks than too few.
>
> Is this a regression to v4.2 that should go to stable or v4.3 material?
Yes it is a regression from v4.0, it applies well on v4.0.9
Fixes: a0b957f306fa ("pinctrl: at91: allow to have disabled gpio bank")
Cc: sta...@vger.kernel.org # 4.0
Thanks
Ludovic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
