Hi Azael, On Mon, Jul 27, 2015 at 07:22:26PM -0600, Azael Avalos wrote: > Currently the driver prints "*not supported" if any of the features > queried are in fact not supported, let us print the available > features instead. > > This patch removes all instances pr_info printing "*not supported", > and add a new function called "print_supported_features", which will > print the available laptop features. > > Signed-off-by: Azael Avalos <[email protected]> > --- > drivers/platform/x86/toshiba_acpi.c | 69 > +++++++++++++++++++++++-------------- > 1 file changed, 44 insertions(+), 25 deletions(-) > > diff --git a/drivers/platform/x86/toshiba_acpi.c > b/drivers/platform/x86/toshiba_acpi.c > index e164926..e24f0f5 100644 > --- a/drivers/platform/x86/toshiba_acpi.c > +++ b/drivers/platform/x86/toshiba_acpi.c > @@ -477,13 +477,10 @@ static void toshiba_illumination_set(struct > led_classdev *cdev, > state = brightness ? 1 : 0; > result = sci_write(dev, SCI_ILLUMINATION, state); > sci_close(dev); > - if (result == TOS_FAILURE) { > + if (result == TOS_FAILURE) > pr_err("ACPI call for illumination failed\n"); > + else if (result == TOS_NOT_SUPPORTED) > return;
And otherwise.... return. So this last if test doesn't do anything. If you feel the context is relevant, consider just including it as a comment. Thanks, -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
