On Wed, 2015-08-05 at 11:37 +0200, Peter Zijlstra wrote: > On Tue, Aug 04, 2015 at 05:29:44PM -0700, Jason Low wrote: > > > @@ -1137,6 +1148,13 @@ static inline int fastpath_timer_check(struct > > task_struct *tsk) > > if (READ_ONCE(sig->cputimer.running)) { > > Maybe make that: > > if (READ_ONCE(sig->cputimer.running) && > !READ_ONCE(sig->cputimer.is_checking_timer)) {
Yes, I think it would be better if the check is done here. And perhaps the comment can be modified to: /* * Check if thread group timers expired. This is skipped if the cputimer * is not running or if another thread in the group is already checking * for thread group cputimers. */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/