Hi, On Tuesday, August 18, 2015 09:15:06 AM Javier Martinez Canillas wrote: > The boolean CROS_EC_PROTO symbol is selected by MFD_CROS_EC but that can > cause Kconfig circular dependencies so is better to change the select to
Could you please give a reference to the problem or error message that you're getting (I was not following the previous discussion). > a depends on. But in order to be able to change that, the CROS_EC_PROTO > symbol has to be one that can be selected by the user. Looking at the code behind the config option it seems that it is just a helper library and should not be made user-visible. Why can't the issue be fixed the other way (make other config options select CROS_EC_PROTO consistently)? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> > --- > drivers/platform/chrome/Kconfig | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig > index 3271cd1abe7c..a73b823d4967 100644 > --- a/drivers/platform/chrome/Kconfig > +++ b/drivers/platform/chrome/Kconfig > @@ -59,8 +59,9 @@ config CROS_EC_LPC > module will be called cros_ec_lpc. > > config CROS_EC_PROTO > - bool > + bool "ChromeOS EC communication protocol helpers" > help > - ChromeOS EC communication protocol helpers. > + Say Y here to enable support for the different communication > + protocols used to talk with the ChromeOS embedded controller. > > endif # CHROMEOS_PLATFORMS -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
