On Tue, Aug 18, 2015 at 4:39 PM, Joe Stringer <joestrin...@nicira.com> wrote: > Add support for using conntrack helpers to assist protocol detection. > The new OVS_CT_ATTR_HELPER attribute of the ct action specifies a helper > to be used for this connection. > > Example ODP flows allowing FTP connections from ports 1->2: > in_port=1,tcp,action=ct(helper=ftp,commit),2 > in_port=2,tcp,ct_state=-trk,action=ct(),recirc(1) > recirc_id=1,in_port=2,tcp,ct_state=+trk-new+est,action=1 > recirc_id=1,in_port=2,tcp,ct_state=+trk+rel,action=1 > > Signed-off-by: Joe Stringer <joestrin...@nicira.com> > --- > v2-v3: No change. > v4: Change error code for unknown helper ENOENT->EINVAL.
I got following compilation warning : net/openvswitch/conntrack.c:352:42: error: incompatible types in comparison expression (different address spaces) > --- > include/uapi/linux/openvswitch.h | 3 ++ > net/openvswitch/conntrack.c | 109 > ++++++++++++++++++++++++++++++++++++++- > 2 files changed, 110 insertions(+), 2 deletions(-) > ... > +static int ovs_ct_add_helper(struct ovs_conntrack_info *info, const char > *name, > + const struct sw_flow_key *key, bool log) > +{ > + struct nf_conntrack_helper *helper; > + struct nf_conn_help *help; > + > + helper = nf_conntrack_helper_try_module_get(name, info->family, > + key->ip.proto); > + if (!helper) { > + OVS_NLERR(log, "Unknown helper \"%s\"", name); > + return -EINVAL; > + } > + > + help = nf_ct_helper_ext_add(info->ct, helper, GFP_KERNEL); > + if (!help) { > + module_put(helper->me); > + return -ENOMEM; > + } > + > + help->helper = helper; helper is rcu pointer so need to use rcu API to set the value. I know it is not required here, but it is still cleaner to use the API. > + info->helper = helper; > + return 0; > +} > + -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/