On Thu, Aug 27, 2015 at 07:49:25AM +0200, Markus Pargmann wrote: > On Wed, Aug 26, 2015 at 06:38:12PM +0100, Mark Brown wrote: > > On Wed, Aug 26, 2015 at 03:22:46PM +0200, Markus Pargmann wrote:
> > > The regmap_bulk_read() function worked before the following patch: > > > 15b8d2c41fe5 (regmap: Fix regmap_bulk_read in BE mode) > > Define "worked" here. > "worked" means here that it did not run into a null pointer and returned > something that the user expected. I am not sure if someone actually > complained about the previous use of memcpy? I also don't know how the > behavior of regmap_bulk_read with reg_read() is defined. Which basically boils down to hacked something that happened to work with the current implementation but wasn't obviously coherent - this is part of the problem, the interface just happened so hasn't been thought through. It's not clear that defining the bit sizes at all without any formatting makes sense, if anything I would have been expecting arrays of unsigned integers to be being passed around since that's how we store unformatted values in regmap. Using memcpy() worries me because we are using memcpy() to move a value that isn't an unsigned long out of an unsigned long and I can't convince myself that this will be safe on big endian systems. If we are going to keep using the val_bits word size then we're going to need to rewrite the values.
signature.asc
Description: Digital signature
