Em Sat, Aug 29, 2015 at 04:22:02AM +0000, Wang Nan escreveu: > Before this patch, add_perf_probe_events() init symbol maps only for > uprobe if the first 'struct perf_probe_event' passed to it is a uprobe > event. This is a trick because 'perf probe''s command line syntax > constrains the first elements of the probe_event arrays must be kprobes > if there is one kprobe there. > > However, with the incoming BPF uprobe support, that constrain is not > hold since 'perf record' will also probe on k/u probes through BPF > object, and is possible to pass an array with kprobe but the first > element is uprobe. > > This patch init symbol maps for kprobes even if all of events are > uprobes, because the extra cost should be small enough.
Masami, are you Ok with this one? - Arnaldo > Signed-off-by: Wang Nan <wangn...@huawei.com> > Cc: Alexei Starovoitov <a...@plumgrid.com> > Cc: Brendan Gregg <brendan.d.gr...@gmail.com> > Cc: Daniel Borkmann <dan...@iogearbox.net> > Cc: David Ahern <dsah...@gmail.com> > Cc: He Kuang <heku...@huawei.com> > Cc: Jiri Olsa <jo...@kernel.org> > Cc: Kaixu Xia <xiaka...@huawei.com> > Cc: Masami Hiramatsu <masami.hiramatsu...@hitachi.com> > Cc: Namhyung Kim <namhy...@kernel.org> > Cc: Paul Mackerras <pau...@samba.org> > Cc: Peter Zijlstra <a.p.zijls...@chello.nl> > Cc: Zefan Li <lize...@huawei.com> > Cc: pi3or...@163.com > Cc: Arnaldo Carvalho de Melo <a...@redhat.com> > Link: > http://lkml.kernel.org/n/1436445342-1402-39-git-send-email-wangn...@huawei.com > --- > tools/perf/util/probe-event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index e720913..b94a8d7 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -2789,7 +2789,7 @@ int add_perf_probe_events(struct perf_probe_event > *pevs, int npevs, > { > int i, ret; > > - ret = init_symbol_maps(pevs->uprobes); > + ret = init_symbol_maps(false); > if (ret < 0) > return ret; > > -- > 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
