> From: Arnaldo Carvalho de Melo [mailto:[email protected]] > > Em Sat, Aug 29, 2015 at 04:22:02AM +0000, Wang Nan escreveu: > > Before this patch, add_perf_probe_events() init symbol maps only for > > uprobe if the first 'struct perf_probe_event' passed to it is a uprobe > > event. This is a trick because 'perf probe''s command line syntax > > constrains the first elements of the probe_event arrays must be kprobes > > if there is one kprobe there. > > > > However, with the incoming BPF uprobe support, that constrain is not > > hold since 'perf record' will also probe on k/u probes through BPF > > object, and is possible to pass an array with kprobe but the first > > element is uprobe. > > > > This patch init symbol maps for kprobes even if all of events are > > uprobes, because the extra cost should be small enough. > > Masami, are you Ok with this one?
Yeah, looks OK for me ! :) Acked-by: Masami Hiramatsu <[email protected]> Thanks! > > - Arnaldo > > > Signed-off-by: Wang Nan <[email protected]> > > Cc: Alexei Starovoitov <[email protected]> > > Cc: Brendan Gregg <[email protected]> > > Cc: Daniel Borkmann <[email protected]> > > Cc: David Ahern <[email protected]> > > Cc: He Kuang <[email protected]> > > Cc: Jiri Olsa <[email protected]> > > Cc: Kaixu Xia <[email protected]> > > Cc: Masami Hiramatsu <[email protected]> > > Cc: Namhyung Kim <[email protected]> > > Cc: Paul Mackerras <[email protected]> > > Cc: Peter Zijlstra <[email protected]> > > Cc: Zefan Li <[email protected]> > > Cc: [email protected] > > Cc: Arnaldo Carvalho de Melo <[email protected]> > > Link: > > http://lkml.kernel.org/n/[email protected] > > --- > > tools/perf/util/probe-event.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > > index e720913..b94a8d7 100644 > > --- a/tools/perf/util/probe-event.c > > +++ b/tools/perf/util/probe-event.c > > @@ -2789,7 +2789,7 @@ int add_perf_probe_events(struct perf_probe_event > > *pevs, int npevs, > > { > > int i, ret; > > > > - ret = init_symbol_maps(pevs->uprobes); > > + ret = init_symbol_maps(false); > > if (ret < 0) > > return ret; > > > > -- > > 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
