Use kmalloc_array instead of kmalloc to allocate memory for an array.
Also, remove the dev_warn for a memory leak, making the if check more
sleek.

Signed-off-by: Muhammad Falak R Wani <falakre...@gmail.com>
---
On suggestion by Joe Perches <j...@perches.com>

Changes since v0
        -remove dev_warn for memory leak
        -remove unnecessary parens for if
---
 drivers/usb/core/driver.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
index 818369a..e0636c1 100644
--- a/drivers/usb/core/driver.c
+++ b/drivers/usb/core/driver.c
@@ -416,12 +416,10 @@ static int usb_unbind_interface(struct device *dev)
                if (ep->streams == 0)
                        continue;
                if (j == 0) {
-                       eps = kmalloc(USB_MAXENDPOINTS * sizeof(void *),
+                       eps = kmalloc_array(USB_MAXENDPOINTS, sizeof(void *),
                                      GFP_KERNEL);
-                       if (!eps) {
-                               dev_warn(dev, "oom, leaking streams\n");
+                       if (!eps)
                                break;
-                       }
                }
                eps[j++] = ep;
        }
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to