On Mon, 14 Sep 2015, Zha, Qipeng wrote: > > > >> > > > >> +#define INIT_REGMAP_IRQ(_irq, _off, _mask) \ > > > >> + [_irq] = { .reg_offset = (_off), .mask = (_mask) } > > > >> + > > > > > > >No, that's not what I asked. > > > > > > >Either this macro is going to be useful to *everyone*, or it's probably > > > >not useful to *anyone*. If it's going to exist, it should exist in the > > > >core header file, not Intel's own. > > > > > > Jones, can we keep current change as for intel's own ? not sure if Mark > > > agree to merge this macro to core regmap header file. > > > Maybe some driver want to initialize regmap_irq structure with > > > different/customed way. > > > Thanks. > > > Is that what Mark said when you submitted this to him? > > No, I don't get feedback from Mark.
Then please at least try. Don't forget to Cc me on the patch. If Mark decides that it's not useful to others, then I will consider it for the Intel-only header. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/