> > >>
> > >> +#define INIT_REGMAP_IRQ(_irq, _off, _mask) \
> > >> + [_irq] = { .reg_offset = (_off), .mask = (_mask) }
> > >> +
> >
> > >No, that's not what I asked.
> >
> > >Either this macro is going to be useful to *everyone*, or it's probably
> > >not useful to *anyone*. If it's going to exist, it should exist in the
> > >core header file, not Intel's own.
> >
> > Jones, can we keep current change as for intel's own ? not sure if Mark
> > agree to merge this macro to core regmap header file.
> > Maybe some driver want to initialize regmap_irq structure with
> > different/customed way.
> > Thanks.
> Is that what Mark said when you submitted this to him?
No, I don't get feedback from Mark.