On 9/17/2015 11:17 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 15 September 2015 11:26 PM, Ray Jui wrote: >> Add DT binding for Broadcom Cygnus PCIe PHYs > > DT binding documentation. > > -Kishon >
Yes will fix the commit message. >> >> Signed-off-by: Ray Jui <r...@broadcom.com> >> Reviewed-by: Arun Parameswaran <apara...@broadcom.com> >> Reviewed-by: JD (Jiandong) Zheng <jdzh...@broadcom.com> >> Reviewed-by: Scott Branden <sbran...@broadcom.com> > > >> --- >> .../bindings/phy/brcm,cygnus-pcie-phy.txt | 30 >> ++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt >> >> diff --git a/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt >> b/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt >> new file mode 100644 >> index 0000000..ba41143 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt >> @@ -0,0 +1,30 @@ >> +Broadcom Cygnus PCIe PHY >> + >> +Required properties: >> +- compatible: Must be "brcm,cygnus-pcie-phy" >> +- reg: base address and length of the PCIe PHY block >> +- #phy-cells: must be <1> >> +The first cell is the PHY ID: >> +0 - PCIe RC 0 >> +1 - PCIe RC 1 >> + >> +Example: >> + pcie_phy: phy@0301d0a0 { >> + compatible = "brcm,cygnus-pcie-phy"; >> + reg = <0x0301d0a0 0x14>; >> + #phy-cells = <1>; >> + }; >> + >> + pcie0: pcie@18012000 { >> + ... >> + ... >> + phys = <&pcie_phy 0>; >> + phy-names = "pcie-phy"; >> + }; >> + >> + pcie1: pcie@18013000 { >> + ... >> + ... >> + phys = <&pcie_phy 1>; >> + phy-names = "pcie-phy"; >> + }; >> Note this binding document will now change due to required changes in the phy driver following code review comments. Each phy will now be represented by a child node and #phy-cells will become 0 for each of the child. Thanks, Ray -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/