On Wed, Sep 23, 2015 at 09:23:02AM +0100, Matt Fleming wrote: > On Mon, 21 Sep, at 05:20:03PM, Vinson Lee wrote: > > On Mon, Sep 14, 2015 at 11:59 PM, tip-bot for Jiri Olsa > > <[email protected]> wrote: > > > Commit-ID: 60a1133a5b39738671eff1e4d77bedc1ee3fa528 > > > Gitweb: > > > http://git.kernel.org/tip/60a1133a5b39738671eff1e4d77bedc1ee3fa528 > > > Author: Jiri Olsa <[email protected]> > > > AuthorDate: Wed, 2 Sep 2015 09:56:44 +0200 > > > Committer: Arnaldo Carvalho de Melo <[email protected]> > > > CommitDate: Mon, 14 Sep 2015 12:50:15 -0300 > > > > > > tools lib api fs: Remove debugfs, tracefs and findfs objects > > > > > > We have all the functionality in fs.c, let's remove unneeded > > > objects. > > > > > > Signed-off-by: Jiri Olsa <[email protected]> > > > Cc: David Ahern <[email protected]> > > > Cc: Matt Fleming <[email protected]> > > > Cc: Namhyung Kim <[email protected]> > > > Cc: Peter Zijlstra <[email protected]> > > > Cc: Raphael Beamonte <[email protected]> > > > Cc: Steven Rostedt <[email protected]> > > > Link: > > > http://lkml.kernel.org/r/[email protected] > > > Signed-off-by: Arnaldo Carvalho de Melo <[email protected]> > > > > Hi. > > > > This commit seems to have introduced a build failure with tools/vm. > > > > $ make -C tools vm > > [...] > > gcc -Wall -Wextra -I../lib/ -o page-types page-types.c ../lib/api/libapi.a > > page-types.c:45:28: fatal error: api/fs/debugfs.h: No such file or directory > > #include <api/fs/debugfs.h> > > Given the ferocious pace of development of tools/perf, is there not > some kind of automated build that happens when new patches are picked > up, before they're pushed out? > > Things are refactored and changed so fast in this area (I dare say > faster than almost any other part of the kernel source tree) that not > having the safety net of automated builds just seems suicidal. > > And that doesn't even begin to cover runtime testing, since I've > noticed things breaking in tools/perf and people not catching it > immediately. > > Does automated testing exist for perf tools development?
heh, we've been playing game "who first mention it in public will implement it" ... you won! ;-) AFAIK we have: - 'perf test' for perf specific functionality - 'make -f tests/make' for building - build framework tests I 'try' to run those before sending anything out, but we dont have automated thing that would run it any time Arnaldo push new perf/core. The RedHat QE has some more perf tool tests. There was some movement to make those public, but not sure how it ended up.. ccing Michael Petlan for news on this ;-) jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
