Hello, On Sun, Sep 27, 2015 at 02:09:24AM +0900, Akinobu Mita wrote: > @@ -420,7 +420,9 @@ static void blk_mq_sysfs_init(struct request_queue *q) > /* see blk_register_queue() */ > void blk_mq_finish_init(struct request_queue *q) > { > + mutex_lock(&q->mq_freeze_lock); > percpu_ref_switch_to_percpu(&q->mq_usage_counter); > + mutex_unlock(&q->mq_freeze_lock);
This looks weird to me. What can it race against at this point? > @@ -115,11 +115,15 @@ void blk_mq_freeze_queue_start(struct request_queue *q) > { > int freeze_depth; > > + mutex_lock(&q->mq_freeze_lock); > + > freeze_depth = atomic_inc_return(&q->mq_freeze_depth); It doesn't have to be an atomic anymore, right? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/