Re: [PATCH 2/4] of: irq: Add support for the new definition of "msi-parent"

[Thomas Gleixner]

On Wed, 23 Sep 2015, Sergei Shtylyov wrote:
> > -   d = irq_find_matching_host(msi_np, DOMAIN_BUS_PLATFORM_MSI);
> > -   if (!d)
> > -           d = irq_find_host(msi_np);
> > -   dev_set_msi_domain(dev, d);
> > +           d = irq_find_matching_host(args.np, DOMAIN_BUS_PLATFORM_MSI);
> > +           if (!d)
> 
>               if (!d) {
> 
> > +                   d = irq_find_host(args.np);
> > +
> > +           if (d) {
> 
>               } else {
> 
> > +                   dev_set_msi_domain(dev, d);
> > +                   return;
> > +           }

Errm, no. How is that equivalent?

Marc:

      d = foo();
      if (!d)
         d = bar();
      if (d) {
         bla(d);
         return;
      }

Yours:

      d = foo();
      if (!d) {
         d = bar();
      } else {
         bla(d);
         return;
      }

Hmm?

Thanks,

        tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/