Mathieu Desnoyers <[EMAIL PROTECTED]> writes:

> This patch adds the Linux Kernel Markers [...]
> Signed-off-by : Mathieu Desnoyers <[EMAIL PROTECTED]>

If it helps,
Acked-by: Frank Ch. Eigler <[EMAIL PROTECTED]>


One question:

> [...]
> +     /* Markers in modules. */ 
> +     list_for_each_entry(mod, &modules, list) {
> +             if (mod->license_gplok)
> +                     found += marker_set_probe_range(name, format, probe,
> +                             mod->markers, mod->markers+mod->num_markers);
> +     }
> [...]
> +EXPORT_SYMBOL(marker_set_probe);

Are you sure the license_gplok check is necessary here?  We should
consider encouraging non-gpl module writers to instrument their code,
to give users a slightly better chance of debugging problems.


- FChE
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to