On Fri, 9 Oct 2015, Greg KH wrote: > On Fri, Oct 09, 2015 at 07:09:15PM +0100, atull wrote: > > On Thu, 8 Oct 2015, Moritz Fischer wrote: > > > > > --- /dev/null > > > +++ b/drivers/fpga/zynq-fpga.c > > > @@ -0,0 +1,478 @@ > > > +/* > > > + * Copyright (c) 2011-2015 Xilinx Inc. > > > + * Copyright (c) 2015, National Instruments Corp. > > > + * > > > + * FPGA Manager Driver for Xilinx Zynq, heavily based on xdevcfg driver > > > + * in their vendor tree. > > > + * > > > + * This program is free software; you can redistribute it and/or modify > > > + * it under the terms of the GNU General Public License as published by > > > + * the Free Software Foundation; version 2 of the License. > > > + * > > > + * This program is distributed in the hope that it will be useful, > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > > + * GNU General Public License for more details. > > > + */ > > > + > > > +#include <linux/clk.h> > > > +#include <linux/completion.h> > > > +#include <linux/delay.h> > > > +#include <linux/dma-mapping.h> > > > +#include <linux/fpga/fpga-mgr.h> > > > +#include <linux/io.h> > > > +#include <linux/iopoll.h> > > > +#include <linux/module.h> > > > +#include <linux/mfd/syscon.h> > > > +#include <linux/of_address.h> > > > +#include <linux/of_irq.h> > > > +#include <linux/interrupt.h> > > > +#include <linux/pm.h> > > > +#include <linux/regmap.h> > > > +#include <linux/string.h> > > > > Hi Moritz, > > > > That was fast! I just have a couple of very minor comments... > > > > Please alphabetize the #includes. > > Bah, who cares about that, it's not a requirement at all. > > greg k-h >
Nice to know! I get slammed every time for that! Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
