Hi Felix, On Tue. 22 Apr. 2025 at 21:08, Felix Maurer <[email protected]> wrote: > This is the initial import of a CAN selftest from can-tests[1] into the > tree. For now, it is just a single test but when agreed on the > structure, we intend to import more tests from can-tests and add > additional test cases.
Excellent initiative! > The goal of moving the CAN selftests into the tree is to align the tests > more closely with the kernel, improve testing of CAN in general, and to > simplify running the tests automatically in the various kernel CI > systems. > > I have cc'ed netdev and its reviewers and maintainers to make sure they > are okay with the location of the tests and the changes to the paths in > MAINTAINERS. The changes should be merged through linux-can-next and > subsequent changes will not go to netdev anymore. I am not a netdev maintainer, just a /drivers/net/can maintainer, but you have my blessing on this. As far the location goes, your proposal makes perfect sense to me. Actually, I can not think of any other places than tools/testing/selftests/net/can for this kind of thing. > [1]: https://github.com/linux-can/can-tests > > Felix Maurer (4): > selftests: can: Import tst-filter from can-tests > selftests: can: use kselftest harness in test_raw_filter > selftests: can: Use fixtures in test_raw_filter > selftests: can: Document test_raw_filter test cases You are doing a lot of change to the original to the point that this is more a full rewrite. I have no intent of reviewing the first patch which is just the copy paste from the original. If no one else has a strong opinion on this, I would rather prefer if you just squash everything and send a single patch with the final result. This will also save you some effort when migrating the other tests. I have a few comments on the individual patches, but overall very good. Thanks a lot! Yours sincerely, Vincent Mailhol
