On 24.04.25 09:45, Vincent Mailhol wrote: [...] >> Felix Maurer (4): >> selftests: can: Import tst-filter from can-tests >> selftests: can: use kselftest harness in test_raw_filter >> selftests: can: Use fixtures in test_raw_filter >> selftests: can: Document test_raw_filter test cases > > You are doing a lot of change to the original to the point that this > is more a full rewrite. I have no intent of reviewing the first patch > which is just the copy paste from the original. If no one else has a > strong opinion on this, I would rather prefer if you just squash > everything and send a single patch with the final result. This will > also save you some effort when migrating the other tests. > > I have a few comments on the individual patches, but overall very > good. Thanks a lot!
Thank you very much for your feedback! I'll silently include most of it and will only reply where I think discussions are necessary. For squashing / keeping this as individual patches: I usually like to have some kind of history available, but here it might not provide a lot of value. I would be fine with squashing as well. If there are any stronger opinions on this, keep them coming. Thanks, Felix
