Hello Mauro, >> The problem is that I check for UNDEFINED so that the .input section >> of the au0828 board definition can be left uninitialized. Otherwise, >> I would have to add something like "num_inputs" to the board >> definition and worry about the value matching the actual number of >> inputs defined. > > num_inputs is a really bad thing. Maybe you can just test if input type is > UNDEFINED and return -EINVAL.
I agree that num_inputs is a bad idea (which is why I didn't do it). There are two cases here. One is when people select an input, where you raised the concern that they pick an input that has a type of UNDEFINED. I agree that is bad, and will fix that. The other issue is why there is an "UNDEFINED" input in the first place and why it is zero instead of -1: I did this because when the .input section is not defined in the board definition, this is what the type will be set to, and I use this logic to tell if the analog subsystem should be loaded at all. >> Do you mean the checkpatch fixes should be done as a separate patch >> too? I assumed you wanted me to fix the original patch to pass make >> checkpatch. Is there a way to do the equivalent of "make checkpatch" >> against particular hg revisions or source files? I'm just trying to >> understand the best way to ensure that all of the issues actually get >> fixed. > > There are two ways: > > 1) v4l/check.pl <file> > This accepts just one file each time; > > 2) hg diff -r <the last review before your patch series> file > v4l/check.pl file > > The check.pl script is just a wrapper for the checkpatch.pl. Its output is > equal to an standard C compiler. So, you can use it on a C error parser for > some gui. Also, the wrapper removes some checks that are ok (the ones for > the lines that adds kernel version checks - since this will be removed anyway > by the submit script). Great. Thanks for taking the time to provide the info. I will use this to do the cleanup and try to get you the patches this weekend. Devin -- Devin J. Heitmueller http://www.devinheitmueller.com AIM: devinheitmueller -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
