On Mon, 2 Nov 2009, Karicheri, Muralidharan wrote: > >> >@@ -301,9 +301,9 @@ static int mt9t031_set_params(struct > >soc_camera_device > >> >*icd, > >> > ret = reg_write(client, MT9T031_WINDOW_WIDTH, rect->width - 1); > >> > if (ret >= 0) > >> > ret = reg_write(client, MT9T031_WINDOW_HEIGHT, > >> >- rect->height + icd->y_skip_top - 1); > >> >+ rect->height - 1); > > > >> Why y_skip_top is removed? > > > >Because noone ever said they needed it? > > > I suggest you keep it. It can have default 0. I have not viewed the > resulting image for the top line to see if it is corrupted. I just > use it to display it to my display device and I am not seeing any > corruption. I need to view the image at some point to check if it has > any corruption.
Ok, I preserved it, although I'm not convinced it is indeed needed. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
