Hi Sakari, On Tuesday, 19 September 2017 14:10:37 EEST Sakari Ailus wrote: > On Tue, Sep 19, 2017 at 01:48:27PM +0300, Laurent Pinchart wrote: > > On Friday, 15 September 2017 17:17:00 EEST Sakari Ailus wrote: > >> In V4L2 the practice is to have the KernelDoc documentation in the > >> header and not in .c source code files. This consequently makes the V4L2 > >> fwnode function documentation part of the Media documentation build. > >> > >> Also correct the link related function and argument naming in > >> documentation. > >> > >> Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> > >> Reviewed-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> > >> Acked-by: Hans Verkuil <hans.verk...@cisco.com> > >> Acked-by: Pavel Machek <pa...@ucw.cz> > > > > I'm still very opposed to this. In addition to increasing the risk of > > documentation becoming stale, it also makes review more difficult. I'm > > reviewing patch 05/25 of this series and I have to jump around the patch > > to verify that the documentation matches the implementation, it's really > > annoying. > > I'd like to have this discussion separately from the patchset, which is > right now in its 13th version. This patch simply makes the current state > consistent; V4L2 async was the only part of V4L2 with KernelDoc > documentation in .c files.
But there's no need to move the documentation at this point until we reach an agreement, is there ? -- Regards, Laurent Pinchart
