On 02/19/2018 02:48 PM, Sakari Ailus wrote:
> Hi Hans,
>
> On Mon, Feb 19, 2018 at 02:30:18PM +0100, Hans Verkuil wrote:
>> On 02/19/2018 02:27 PM, Sakari Ailus wrote:
>>> These sensor drivers have use case specific mode lists. There's no need
>>> for this nor there is a standard API for selecting the mode list. Disable
>>> configurations for non-preview modes until configuration selection is
>>> improved so that all the configurations are always usable.
>>
>> It's a bit confusing. This seems contradictory: if there is no need for it,
>> then it can be removed. Or there is a need for it, but we don't have a
>> standard API to do it. You can't have both, can you?
>>
>> Or did you mean that this functionality is currently unused, and that if
>> we wanted to use it, we first need a new API? That would actually make sense.
>
> Correct. All it takes might be just to put these modes to the common list.
> But I can't test that as I have no hardware. It's easy to implement that
> later on though, that's the idea.
>
I've reworded the second sentence slightly:
"These sensor drivers have use case specific mode lists. This is currently
not used nor there is a standard API for selecting the mode list. Disable
configurations for non-preview modes until configuration selection is
improved so that all the configurations are always usable."
Is that OK?
Regards,
Hans
