Hi Dafna, Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20190215] [cannot apply to v5.0-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Dafna-Hirschfeld/add-support-to-stateless-decoder/20190216-051151 base: git://linuxtv.org/media_tree.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' All error/warnings (new ones prefixed by >>): >> drivers/media/platform/vicodec/vicodec-core.c:180:6: sparse: warning: symbol >> 'validate_stateless_params_flags' was not declared. Should it be static? >> drivers/media/platform/vicodec/vicodec-core.c:1614:15: sparse: error: no >> member 'requires_requests' in struct vb2_queue >> drivers/media/platform/vicodec/vicodec-core.c:1614:15: sparse: warning: >> generating address of non-lvalue (8) vim +/requires_requests +1614 drivers/media/platform/vicodec/vicodec-core.c 256bf813 Hans Verkuil 2018-07-20 1591 256bf813 Hans Verkuil 2018-07-20 1592 static int queue_init(void *priv, struct vb2_queue *src_vq, 256bf813 Hans Verkuil 2018-07-20 1593 struct vb2_queue *dst_vq) 256bf813 Hans Verkuil 2018-07-20 1594 { 256bf813 Hans Verkuil 2018-07-20 1595 struct vicodec_ctx *ctx = priv; 256bf813 Hans Verkuil 2018-07-20 1596 int ret; 256bf813 Hans Verkuil 2018-07-20 1597 256bf813 Hans Verkuil 2018-07-20 1598 src_vq->type = (multiplanar ? 256bf813 Hans Verkuil 2018-07-20 1599 V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE : 256bf813 Hans Verkuil 2018-07-20 1600 V4L2_BUF_TYPE_VIDEO_OUTPUT); 256bf813 Hans Verkuil 2018-07-20 1601 src_vq->io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF; 256bf813 Hans Verkuil 2018-07-20 1602 src_vq->drv_priv = ctx; 256bf813 Hans Verkuil 2018-07-20 1603 src_vq->buf_struct_size = sizeof(struct v4l2_m2m_buffer); 256bf813 Hans Verkuil 2018-07-20 1604 src_vq->ops = &vicodec_qops; 256bf813 Hans Verkuil 2018-07-20 1605 src_vq->mem_ops = &vb2_vmalloc_memops; 256bf813 Hans Verkuil 2018-07-20 1606 src_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY; c6f483ff Dafna Hirschfeld 2019-02-15 1607 if (ctx->is_enc) c6f483ff Dafna Hirschfeld 2019-02-15 1608 src_vq->lock = &ctx->dev->stateful_enc.mutex; c6f483ff Dafna Hirschfeld 2019-02-15 1609 else if (ctx->is_stateless) c6f483ff Dafna Hirschfeld 2019-02-15 1610 src_vq->lock = &ctx->dev->stateless_dec.mutex; c6f483ff Dafna Hirschfeld 2019-02-15 1611 else c6f483ff Dafna Hirschfeld 2019-02-15 1612 src_vq->lock = &ctx->dev->stateful_dec.mutex; c6f483ff Dafna Hirschfeld 2019-02-15 1613 src_vq->supports_requests = ctx->is_stateless ? true : false; c6f483ff Dafna Hirschfeld 2019-02-15 @1614 src_vq->requires_requests = ctx->is_stateless ? true : false; 256bf813 Hans Verkuil 2018-07-20 1615 ret = vb2_queue_init(src_vq); 256bf813 Hans Verkuil 2018-07-20 1616 if (ret) 256bf813 Hans Verkuil 2018-07-20 1617 return ret; 256bf813 Hans Verkuil 2018-07-20 1618 256bf813 Hans Verkuil 2018-07-20 1619 dst_vq->type = (multiplanar ? 256bf813 Hans Verkuil 2018-07-20 1620 V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE : 256bf813 Hans Verkuil 2018-07-20 1621 V4L2_BUF_TYPE_VIDEO_CAPTURE); 256bf813 Hans Verkuil 2018-07-20 1622 dst_vq->io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF; 256bf813 Hans Verkuil 2018-07-20 1623 dst_vq->drv_priv = ctx; 256bf813 Hans Verkuil 2018-07-20 1624 dst_vq->buf_struct_size = sizeof(struct v4l2_m2m_buffer); 256bf813 Hans Verkuil 2018-07-20 1625 dst_vq->ops = &vicodec_qops; 256bf813 Hans Verkuil 2018-07-20 1626 dst_vq->mem_ops = &vb2_vmalloc_memops; 256bf813 Hans Verkuil 2018-07-20 1627 dst_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY; 256bf813 Hans Verkuil 2018-07-20 1628 dst_vq->lock = src_vq->lock; 256bf813 Hans Verkuil 2018-07-20 1629 256bf813 Hans Verkuil 2018-07-20 1630 return vb2_queue_init(dst_vq); 256bf813 Hans Verkuil 2018-07-20 1631 } 256bf813 Hans Verkuil 2018-07-20 1632 :::::: The code at line 1614 was first introduced by commit :::::: c6f483ff724e70555c1725705674f22c0ba0a119 media: vicodec: Register another node for stateless decoder :::::: TO: Dafna Hirschfeld <[email protected]> :::::: CC: 0day robot <[email protected]> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
