On Wed, May 05, 2010 at 12:30:01PM -0300, Mauro Carvalho Chehab wrote: > This simplifies the code a little bit, and, instead of just return -EINVAL, > it will return the error condition reported by the called functions. >
Thanks for that. There was one return that got missed. Probably you can fold it into your patch? Signed-off-by: Dan Carpenter <[email protected]> diff --git a/drivers/staging/cx25821/cx25821-medusa-video.c b/drivers/staging/cx25821/cx25821-medusa-video.c index 7545314..34616dc 100644 --- a/drivers/staging/cx25821/cx25821-medusa-video.c +++ b/drivers/staging/cx25821/cx25821-medusa-video.c @@ -849,10 +849,8 @@ int medusa_video_init(struct cx25821_dev *dev) value |= 7; ret_val = cx25821_i2c_write(&dev->i2c_bus[0], PIN_OE_CTRL, value); - if (ret_val < 0) { - mutex_unlock(&dev->lock); - return -EINVAL; - } + if (ret_val < 0) + goto error; mutex_unlock(&dev->lock); -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
