On Monday 12 July 2010 17:25:47 Laurent Pinchart wrote:
> There's no reason to require subdevices to implement the core
> operations. Remove the check for non-NULL core operations when
> initializing the subdev.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>

Acked-by: Hans Verkuil <hverk...@xs4all.nl>

> ---
>  include/media/v4l2-subdev.h |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> index 02c6f4d..6088316 100644
> --- a/include/media/v4l2-subdev.h
> +++ b/include/media/v4l2-subdev.h
> @@ -437,8 +437,7 @@ static inline void v4l2_subdev_init(struct v4l2_subdev 
> *sd,
>                                       const struct v4l2_subdev_ops *ops)
>  {
>       INIT_LIST_HEAD(&sd->list);
> -     /* ops->core MUST be set */
> -     BUG_ON(!ops || !ops->core);
> +     BUG_ON(!ops);
>       sd->ops = ops;
>       sd->v4l2_dev = NULL;
>       sd->flags = 0;
> 

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to