Laurent Pinchart wrote:
@@ -543,6 +594,14 @@ static int smiapp_init_controls(struct smiapp_sensor
*sensor) goto error;
}
+ for (i = 0; i < ARRAY_SIZE(sensor->test_data); i++) {
+ struct v4l2_ctrl *ctrl = sensor->test_data[i];
+
+ ctrl->maximum =
+ ctrl->default_value =
+ ctrl->cur.val = (1 << sensor->csi_format->width) - 1;
I think multiple assignments on the same line are discouraged.
Furthermore, couldn't you move this above and use the right values directly
when creating the controls ?
Good point. There might have been a reason to do this in a past version
of the patch but it no longer exists.
--
Sakari Ailus
sakari.ai...@linux.intel.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html