Hi Daniel,
Intentional.
if no vqmmc regulator then just assume it will work.
if there is a regulator it needs to support 1.8V. (If I remember correctly UHS
mode require 1.8V vccq) I need to check if we 1.2V should be allowed but it
was not in the spec that I had.
Are you thinking we need 1.2V support ?
regards,
Philip
On Oct 30, 2012, at 9:30 PM, Daniel Drake <d...@laptop.org> wrote:
> Hi,
>
> Please check this commit:
>
>
> commit 6231f3de1332b2a8a90e0c598ab6acc8f1eff7c1
> Author: Philip Rakity <prak...@marvell.com>
> Date: Mon Jul 23 15:56:23 2012 -0700
>
> mmc: sdhci: Add regulator support for vccq (voltage regualor)
>
> Particularly this hunk:
>
> + /* If vqmmc regulator and no 1.8V signalling, then there's no UHS */
> + host->vqmmc = regulator_get(mmc_dev(mmc), "vqmmc");
> + if (IS_ERR(host->vqmmc)) {
> + pr_info("%s: no vqmmc regulator found\n", mmc_hostname(mmc));
> + host->vqmmc = NULL;
> + }
> + else if (regulator_is_supported_voltage(host->vqmmc, 1800000,
> 1800000))
> + regulator_enable(host->vqmmc);
> + else
> + caps[1] &= ~(SDHCI_SUPPORT_SDR104 | SDHCI_SUPPORT_SDR50 |
> + SDHCI_SUPPORT_DDR50);
>
> One effect of this code is that if the system has no vqmmc regulator,
> the UHS-I flags are always cleared on the final line, so the ultra
> speed mode is always disabled.
>
> Is this intentional or is there a check missing?
>
> Thanks
> Daniel
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may
contain
confidential information. Any unauthorized review, use, disclosure or
distribution
is prohibited. If you are not the intended recipient, please contact the
sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
